Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1020#discussion_r149349985
--- Diff: exec/java-exec/src/main/resources/rest/metrics/metrics.ftl ---
@@ -138,21 +154,14 @@
});
};
- function updateOthers(metrics) {
- $.each(["counters", "meters"], function(i, key) {
- if(! $.isEmptyObject(metrics[key])) {
- $("#" + key + "Val").html(JSON.stringify(metrics[key], null, 2));
- }
- });
- };
-
var update = function() {
$.get("/status/metrics", function(metrics) {
updateGauges(metrics.gauges);
updateBars(metrics.gauges);
if(! $.isEmptyObject(metrics.timers)) createTable(metrics.timers,
"timers");
if(! $.isEmptyObject(metrics.histograms))
createTable(metrics.histograms, "histograms");
- updateOthers(metrics);
+ if(! $.isEmptyObject(metrics.counters))
createCountersTable(metrics.counters);
+ if(! $.isEmptyObject(metrics.meters))
$("#metersVal").html(JSON.stringify(metrics.meters, null, 2));
--- End diff --
@prasadns14
1. Please add two screenshots before and after the changes.
2. Can you please think of the way to make create table generic so can be
used for timers, histograms and counters?
3. What about meters? How they are displayed right now? Maybe we need to
display them in table as well?
Ideally, we can display all metrics in the same way.
---
