Github user vvysotskyi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/904#discussion_r149440392
  
    --- Diff: 
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/testing/TestDateConversions.java
 ---
    @@ -225,4 +243,16 @@ public void testPostgresDateFormatError() throws 
Exception {
           throw e;
         }
       }
    +
    +  /**
    +   * mock current locale to US
    +   */
    +  private void mockUSLocale() {
    --- End diff --
    
    Please move this method into ExecTest class and make it public and static.


---

Reply via email to