Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/1024#discussion_r149474798 --- Diff: exec/jdbc/src/test/java/org/apache/drill/jdbc/PreparedStatementTest.java --- @@ -237,6 +245,127 @@ public String toString() { } } + /** + * Test for reading of default query timeout + */ + @Test + public void testDefaultGetQueryTimeout() throws SQLException { + PreparedStatement stmt = connection.prepareStatement(SYS_VERSION_SQL); + int timeoutValue = stmt.getQueryTimeout(); + assert( 0 == timeoutValue ); + } + + /** + * Test Invalid parameter by giving negative timeout + */ + @Test ( expected = InvalidParameterSqlException.class ) + public void testInvalidSetQueryTimeout() throws SQLException { + PreparedStatement stmt = connection.prepareStatement(SYS_VERSION_SQL); + //Setting negative value + int valueToSet = -10; + if (0L == valueToSet) { --- End diff -- My bad. The original code would assign the negation of a random integer.,.. hence the check for 0L and followed by a decrement. +1
---