Github user vrozov commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1027#discussion_r150019576
  
    --- Diff: contrib/storage-kafka/pom.xml ---
    @@ -0,0 +1,130 @@
    +<?xml version="1.0"?>
    +<!-- Licensed to the Apache Software Foundation (ASF) under one or more 
contributor
    +  license agreements. See the NOTICE file distributed with this work for 
additional
    +  information regarding copyright ownership. The ASF licenses this file to
    +  You under the Apache License, Version 2.0 (the "License"); you may not 
use
    +  this file except in compliance with the License. You may obtain a copy of
    +  the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required
    +  by applicable law or agreed to in writing, software distributed under the
    +  License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR 
CONDITIONS
    +  OF ANY KIND, either express or implied. See the License for the specific
    +  language governing permissions and limitations under the License. -->
    +<project
    +  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";
    +  xmlns="http://maven.apache.org/POM/4.0.0"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";>
    +  <modelVersion>4.0.0</modelVersion>
    +
    +  <parent>
    +    <artifactId>drill-contrib-parent</artifactId>
    +    <groupId>org.apache.drill.contrib</groupId>
    +    <version>1.12.0-SNAPSHOT</version>
    +  </parent>
    +
    +  <artifactId>drill-storage-kafka</artifactId>
    +  <name>contrib/kafka-storage-plugin</name>
    +
    +  <properties>
    +    <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
    --- End diff --
    
    If the setting is necessary, it will be better to set it at the root pom.


---

Reply via email to