[GitHub] drill pull request #914: DRILL-5657: Size-aware vector writer structure

[parthchandra]

Github user parthchandra commented on a diff in the pull request:

    https://github.com/apache/drill/pull/914#discussion_r149760234
  
    --- Diff: 
exec/java-exec/src/test/java/org/apache/drill/test/rowSet/test/RowSetTest.java 
---
    @@ -19,420 +19,648 @@
     
     import static org.junit.Assert.assertEquals;
     import static org.junit.Assert.assertFalse;
    -import static org.junit.Assert.assertNotNull;
    -import static org.junit.Assert.assertNull;
     import static org.junit.Assert.assertSame;
     import static org.junit.Assert.assertTrue;
    +import static org.junit.Assert.fail;
    +
    +import java.io.UnsupportedEncodingException;
     
    -import org.apache.drill.common.types.TypeProtos.DataMode;
     import org.apache.drill.common.types.TypeProtos.MinorType;
     import org.apache.drill.exec.record.BatchSchema;
    +import org.apache.drill.exec.record.TupleMetadata;
    +import org.apache.drill.exec.vector.ValueVector;
     import org.apache.drill.exec.vector.accessor.ArrayReader;
     import org.apache.drill.exec.vector.accessor.ArrayWriter;
    -import org.apache.drill.exec.vector.accessor.TupleAccessor.TupleSchema;
    +import org.apache.drill.exec.vector.accessor.ObjectType;
    +import org.apache.drill.exec.vector.accessor.ScalarElementReader;
    +import org.apache.drill.exec.vector.accessor.ScalarReader;
    +import org.apache.drill.exec.vector.accessor.ScalarWriter;
    +import org.apache.drill.exec.vector.accessor.TupleReader;
    +import org.apache.drill.exec.vector.accessor.TupleWriter;
    +import org.apache.drill.exec.vector.accessor.ValueType;
    +import org.apache.drill.exec.vector.complex.MapVector;
    +import org.apache.drill.exec.vector.complex.RepeatedMapVector;
     import org.apache.drill.test.SubOperatorTest;
     import org.apache.drill.test.rowSet.RowSet.ExtendableRowSet;
    -import org.apache.drill.test.rowSet.RowSet.RowSetReader;
    -import org.apache.drill.test.rowSet.RowSet.RowSetWriter;
     import org.apache.drill.test.rowSet.RowSet.SingleRowSet;
     import org.apache.drill.test.rowSet.RowSetComparison;
    -import org.apache.drill.test.rowSet.RowSetSchema;
    -import org.apache.drill.test.rowSet.RowSetSchema.FlattenedSchema;
    -import org.apache.drill.test.rowSet.RowSetSchema.PhysicalSchema;
    +import org.apache.drill.test.rowSet.RowSetReader;
    +import org.apache.drill.test.rowSet.RowSetWriter;
     import org.apache.drill.test.rowSet.SchemaBuilder;
    +import org.bouncycastle.util.Arrays;
    --- End diff --
    
    BouncyCastle arrays instead of Java Arrays ?


---