Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1026#discussion_r150359353
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/JsonConvertFrom.java
---
@@ -50,7 +51,7 @@ private JsonConvertFrom(){}
@Output ComplexWriter writer;
public void setup(){
- jsonReader = new
org.apache.drill.exec.vector.complex.fn.JsonReader(buffer, false, false, false
/* do not read numbers as doubles */);
+ jsonReader = new
org.apache.drill.exec.vector.complex.fn.JsonReader(buffer, false, false, false,
false /* do not read numbers as doubles */);
--- End diff --
Here, the comment refers to the second-to-last item. Consider this:
```
false, // What is the first one?
false, // What is the second one?
false, // do not read numbers as doubles
false // Do not allow Nan, INF
```
---
