[GitHub] drill pull request #1033: DRILL-5952: Implement "CREATE TABLE IF NOT EXISTS"

[arina-ielchiieva]

Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1033#discussion_r150512944
  
    --- Diff: exec/java-exec/src/main/codegen/includes/parserImpls.ftl ---
    @@ -241,8 +243,8 @@ SqlNode SqlCreateTable() :
         <AS>
         query = OrderedQueryOrExpr(ExprContext.ACCEPT_QUERY)
         {
    -        return new SqlCreateTable(pos,tblName, fieldList, 
partitionFieldList, query,
    -                                    SqlLiteral.createBoolean(isTemporary, 
getPos()));
    +        return new SqlCreateTable(pos, 
SqlLiteral.createBoolean(tableNonExistenceCheck, getPos()), tblName, fieldList,
    --- End diff --
    
    Not sure if it is a good practice to add new parameter in the beginning of 
constructor rather in the end.


---