Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/921#discussion_r150984396
  
    --- Diff: 
exec/java-exec/src/test/java/org/apache/drill/test/ClusterFixture.java ---
    @@ -471,6 +471,21 @@ public void close() throws Exception {
       }
     
       /**
    +   * Shutdown the drillbit given the name of the drillbit.
    +   */
    +  public void closeDrillbit(final String drillbitName) throws Exception {
    +    Exception ex = null;
    +    for (Drillbit bit : drillbits()) {
    +      if(bit.equals(bits.get(drillbitName))) {
    +        bit.close();
    +      }
    +    }
    +    if(ex != null) {
    --- End diff --
    
    Looks like `ex` is declared, but never set. Was the goal to capture 
exceptions from `bit.close()`?


---

Reply via email to