Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1027#discussion_r151583298
  
    --- Diff: contrib/storage-kafka/src/main/resources/drill-module.conf ---
    @@ -0,0 +1,30 @@
    +// Licensed to the Apache Software Foundation (ASF) under one or more
    +// contributor license agreements.  See the NOTICE file distributed with
    +// this work for additional information regarding copyright ownership.
    +// The ASF licenses this file to You under the Apache License, Version 2.0
    +// (the "License"); you may not use this file except in compliance with
    +// the License.  You may obtain a copy of the License at
    +//
    +//     http://www.apache.org/licenses/LICENSE-2.0
    +//
    +// Unless required by applicable law or agreed to in writing, software
    +// distributed under the License is distributed on an "AS IS" BASIS,
    +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +// See the License for the specific language governing permissions and
    +// limitations under the License.
    +//
    +//  This file tells Drill to consider this module when class path scanning.
    +//  This file can also include any supplementary configuration information.
    +//  This file is in HOCON format, see 
https://github.com/typesafehub/config/blob/master/HOCON.md for more information.
    +drill.classpath.scanning: {
    +  packages += "org.apache.drill.exec.store.kafka"
    +}
    +drill.exec: {
    +
    +  sys.store.provider: {
    +    kafka : {
    +      "kafkaConsumerProps" : "{\"bootstrap.servers\" : \"localhost:9092\"}"
    --- End diff --
    
    These appear to be things that users will need to set. If so, our usual 
convention is to create example entries in drill-override-example.conf, along 
with comments that explain the properties.


---

Reply via email to