Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1027#discussion_r152286833
  
    --- Diff: 
contrib/storage-kafka/src/test/java/org/apache/drill/exec/store/kafka/decoders/MessageReaderFactoryTest.java
 ---
    @@ -0,0 +1,64 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.store.kafka.decoders;
    +
    +import org.apache.drill.common.exceptions.UserException;
    +import org.apache.drill.exec.proto.UserBitShared.DrillPBError.ErrorType;
    +import org.junit.Assert;
    +import org.junit.Test;
    +
    +public class MessageReaderFactoryTest {
    +
    +  @Test
    +  public void testShouldThrowExceptionAsMessageReaderIsNull() {
    --- End diff --
    
    Please check the below tests, they can give false positive result as well.


---

Reply via email to