Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/1043
Very nice, @cgivre ! I've been looking to do something similar for the SQL
side as well, but with autocomplete support. Let's talk about that separately.
We just need to make sure that there are no license/usage issues. Would be nice
if we can leverage this into the SQL Editor as well. Let's talk over this
offline.
I know I had a discussion recently with someone regarding validation of the
JSON for the storage plugin, but that will be a stretch. Also, it seems like
the library can recognize single line comments ( // ), which (I believe) is
supported by Drill JSON config parser.
Can you pick a theme that helps visibly pop out the colors more than it
currently is? Crimson or Eclipse themes look better, helping visualize.
Also, if the 'src-min-noconflict' is primarily to support the ace libraries
and you don't want to risk renaming the library files, it's good to give it a
more meaningful name (indicating that it contains AceJS libraries).
Otherwise, LGTM
+1
---
