Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1050#discussion_r152773573
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceConfig.java
 ---
    @@ -30,18 +30,24 @@
     public class WorkspaceConfig {
     
       /** Default workspace is a root directory which supports read, but not 
write. */
    -  public static final WorkspaceConfig DEFAULT = new WorkspaceConfig("/", 
false, null);
    +  public static final WorkspaceConfig DEFAULT = new WorkspaceConfig("/", 
false, null, false);
     
       private final String location;
       private final boolean writable;
       private final String defaultInputFormat;
    -
    +  private final Boolean allowAccessOutsideWorkspace; // allow access 
outside the workspace by default. This
    --- End diff --
    
    Consider using primitive, we don't want unnecessary boxing / unboxing.


---

Reply via email to