Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/1024#discussion_r155402523
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java ---
@@ -156,29 +156,19 @@ public void cleanUp() {
}
@Override
- public int getQueryTimeout() throws AlreadyClosedSqlException
+ public int getQueryTimeout() throws AlreadyClosedSqlException,
SQLException
{
throwIfClosed();
- return 0; // (No no timeout.)
+ return super.getQueryTimeout();
}
@Override
- public void setQueryTimeout( int milliseconds )
+ public void setQueryTimeout( int seconds )
throws AlreadyClosedSqlException,
InvalidParameterSqlException,
- SQLFeatureNotSupportedException {
+ SQLException {
--- End diff --
the parent setQueryTimeout will throw a SQLException if the parameter is
invalid, so this method now no longer throws an InvalidParameterSqlException
---
