Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1070#discussion_r158331061 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/XXHash.java --- @@ -166,9 +164,7 @@ public static long hash64(double val, long seed){ } public static long hash64(long start, long end, DrillBuf buffer, long seed){ - if (BoundsChecking.BOUNDS_CHECKING_ENABLED) { - buffer.checkBytes((int)start, (int)end); - } + rangeCheck(buffer, (int)start, (int)end); --- End diff -- I don't see `XXHash` class being used anymore and it possibly can be removed as a follow up for DRILL-4237 and DRILL-4478. I'd prefer to limit this PR to bounds checking functionality.
---