Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r158593774
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestHashJoinAdvanced.java
---
@@ -160,4 +166,51 @@ public void testJoinWithMapAndDotField() throws
Exception {
.baselineValues("1", "2", "1", null, "a")
.go();
}
+
+ private void buildFile(String fileName, String[] data, File testDir)
throws IOException {
+ try(PrintWriter out = new PrintWriter(new FileWriter(new File(testDir,
fileName)))) {
+ for (String line : data) {
+ out.println(line);
+ }
+ }
+ }
+
+ @Test
+ public void testHashLeftJoinWithEmptyTable() throws Exception {
--- End diff --
Should the tests be repeated for
* Empty on left
* Empty on right
* Empty on both
---
