Github user sachouche commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1072#discussion_r160765882
  
    --- Diff: 
exec/java-exec/src/test/java/org/apache/drill/exec/expr/fn/impl/TestSqlPatterns.java
 ---
    @@ -446,6 +446,61 @@ public void testSqlPatternComplex() {
         assertEquals(1, sqlPatternComplex.match(0, byteBuffer.limit(), 
drillBuf)); // should match
       }
     
    +  @Test
    +  public void testSqlPatternContainsMUltipleMatchers() {
    --- End diff --
    
    Paul, the test-suite already has many other tests for SQL matching. But I 
agree, they now might hit only few of these matcher. I will add more tests.


---

Reply via email to