Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1092#discussion_r162331112
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/LogInLogOutResources.java
---
@@ -132,24 +133,26 @@ public Viewable getMainLoginPage(@Context
HttpServletRequest request, @Context H
@Context SecurityContext sc, @Context
UriInfo uriInfo,
@QueryParam(WebServerConstants.REDIRECT_QUERY_PARM) String redirect) throws
Exception {
updateSessionRedirectInfo(redirect, request);
- final DrillConfig drillConfig = workManager.getContext().getConfig();
- MainLoginPageModel model = new MainLoginPageModel(null, drillConfig);
+ final MainLoginPageModel model = new MainLoginPageModel(null);
return ViewableWithPermissions.createMainLoginPage(model);
}
- private class MainLoginPageModel {
+ @VisibleForTesting
+ class MainLoginPageModel {
private final String error;
private final boolean authEnabled;
+ private final DrillConfig config;
--- End diff --
It looks like you are using config only in constructor, so it can not store
it in class.
---
