Github user sachouche commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1060#discussion_r162828174
  
    --- Diff: exec/vector/src/main/codegen/templates/NullableValueVectors.java 
---
    @@ -51,6 +57,17 @@
     public final class ${className} extends BaseDataValueVector implements 
<#if type.major == "VarLen">VariableWidth<#else>FixedWidth</#if>Vector, 
NullableVector {
       private static final org.slf4j.Logger logger = 
org.slf4j.LoggerFactory.getLogger(${className}.class);
     
    +  /**
    +   * Optimization to set contiguous values nullable state in a bulk 
manner; cannot define this array
    +   * within the Mutator class as Java doesn't allow static initialization 
within a non static inner class.
    +   */
    +  private static final int DEFINED_VALUES_ARRAY_LEN = 1 << 10;
    --- End diff --
    
    1 << 10 is 1024; not sure how did you arrive at 10,000,000,000..


---

Reply via email to