Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1090#discussion_r163093639
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/xsort/managed/TestSortImpl.java
---
@@ -466,10 +469,10 @@ public void runLargeSortTest(OperatorFixture fixture,
DataGenerator dataGen,
public void runJumboBatchTest(OperatorFixture fixture, int rowCount) {
timer.reset();
- DataGenerator dataGen = new DataGenerator(fixture, rowCount,
Character.MAX_VALUE);
- DataValidator validator = new DataValidator(rowCount,
Character.MAX_VALUE);
+ DataGenerator dataGen = new DataGenerator(fixture, rowCount,
ValueVector.MAX_ROW_COUNT);
--- End diff --
Will it be better to use
```
DataGenerator dataGen = new DataGenerator(fixture, rowCount,
Integer.MAX_VALUE);
DataValidator validator = new DataValidator(rowCount, Integer.MAX_VALUE);
```
my understanding is that idea is to use max batch size in the test.
---
