Github user reudismam commented on a diff in the pull request:
https://github.com/apache/drill/pull/1099#discussion_r164076111
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ssl/SSLConfigClient.java ---
@@ -94,7 +94,7 @@ private String getStringProperty(String name, String
defaultValue) {
private int getIntProperty(String name, int defaultValue) {
int value = defaultValue;
if ( (properties != null) && (properties.containsKey(name))) {
- value = new Integer(properties.getProperty(name)).intValue();
+ value = Integer.valueOf(properties.getProperty(name)).intValue();
--- End diff --
According to Java documentation, there are benefits in using valueOf for
Double and Float.
https://docs.oracle.com/javase/7/docs/api/java/lang/Double.html#valueOf(double)
https://docs.oracle.com/javase/7/docs/api/java/lang/Float.html#valueOf(float)
---
