Hi Paul, Looking at your PR plan, I am guessing that the CSV reader changes and the JSON reader changes are independent, right? If yes, I would like to propose that you open a PR for the CSV reader first. That will give us one more way to start exercising and maturing the accessor framework while the other layers are changing to adapt to it.
Thanks. Karthik On January 29, 2018 at 11:04:05 PM, Paul Rogers (par0...@yahoo.com.invalid<mailto:par0...@yahoo.com.invalid>) wrote: Hi All, Let's discuss the next step for the "batch handling" project. [1] Thanks to Aman for committing the "hygiene" PR. I'm rebasing the remaining code on the updated master. I'll keep the "RowSetRev3" [2] branch unchanged since [1] has many links to it. Instead I'll create a new branch. It seems to work best to keep the PRs small as outlined in [3]. So, I'm thinking to carve off just the metadata enhancements for the next PR. (Or, if that is awkward, I'll slice of some other small piece.) Doing this work is a bit tedious because I'll have to do temporary edits to files outside the merged changes; and those changes will show up as code conflicts in later PRs. Still, this bit-by-bit approach may work better than a single monster PR. Thoughts or suggestions? Thanks, - Paul [1] https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_paul-2Drogers_drill_wiki_Batch-2DHandling-2DUpgrades&d=DwIFaQ&c=cskdkSMqhcnjZxdQVpwTXg&r=HlugibuI4IVjs-VMnFvNTcaBtEaDDqE4Ya96cugWqJ8&m=VpQRC58vkbPxqjvx_a-4PBqDWTJFqU8OiaS5RGtjwWc&s=0xNXZSGqFVo34ETmcenh7NjhFPizbDRFmKg8EQjpNTk&e= [2] https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_paul-2Drogers_drill_tree_RowSetRev3&d=DwIFaQ&c=cskdkSMqhcnjZxdQVpwTXg&r=HlugibuI4IVjs-VMnFvNTcaBtEaDDqE4Ya96cugWqJ8&m=VpQRC58vkbPxqjvx_a-4PBqDWTJFqU8OiaS5RGtjwWc&s=Vwm5mNIpYEPwXW0qHHhKB_tDIhSxbzwZ9hR_dmmnOl4&e= [3] https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_paul-2Drogers_drill_wiki_BH-2DCode-2DIntro-23pull-2Drequest-2Dplan&d=DwIFaQ&c=cskdkSMqhcnjZxdQVpwTXg&r=HlugibuI4IVjs-VMnFvNTcaBtEaDDqE4Ya96cugWqJ8&m=VpQRC58vkbPxqjvx_a-4PBqDWTJFqU8OiaS5RGtjwWc&s=Pf876M41GizQ_AKPI3wohYrcwF-vx__nZw9NqXIAw8E&e=
