Github user vvysotskyi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1104#discussion_r166310161
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java
 ---
    @@ -596,10 +596,10 @@ private void classifyExpr(final NamedExpression ex, 
final RecordBatch incoming,
         final NameSegment ref = ex.getRef().getRootSegment();
         final boolean exprHasPrefix = 
expr.getPath().contains(StarColumnHelper.PREFIX_DELIMITER);
         final boolean refHasPrefix = 
ref.getPath().contains(StarColumnHelper.PREFIX_DELIMITER);
    -    final boolean exprIsStar = expr.getPath().equals(SchemaPath.WILDCARD);
    -    final boolean refContainsStar = 
ref.getPath().contains(SchemaPath.WILDCARD);
    -    final boolean exprContainsStar = 
expr.getPath().contains(SchemaPath.WILDCARD);
    -    final boolean refEndsWithStar = 
ref.getPath().endsWith(SchemaPath.WILDCARD);
    +    final boolean exprIsStar = 
expr.getPath().equals(SchemaPath.DYNAMIC_STAR);
    --- End diff --
    
    This change became required after Calcite update. With the changes in 
CALCITE-1150, `*` is replaced by `**` after a query is parsed and `**` is added 
to the RowType. Therefore WILDCARD can't come from the plan and its usage 
should be replaced by `**`.


---

Reply via email to