Github user vdiravka commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1111#discussion_r166679633
  
    --- Diff: contrib/storage-hive/hive-exec-shade/pom.xml ---
    @@ -39,23 +39,28 @@
               <groupId>log4j</groupId>
             </exclusion>
             <exclusion>
    -          <groupId>commons-codec</groupId>
    -          <artifactId>commons-codec</artifactId>
    -        </exclusion>
    -        <exclusion>
    -          <artifactId>calcite-avatica</artifactId>
    -          <groupId>org.apache.calcite</groupId>
    +          <groupId>org.json</groupId>
    +          <artifactId>json</artifactId>
             </exclusion>
           </exclusions>
         </dependency>
    +    <dependency>
    +      <groupId>org.apache.parquet</groupId>
    +      <artifactId>parquet-column</artifactId>
    +      <version>${parquet.version}</version>
    --- End diff --
    
    Hive parquet dependencies cause an issues in Drill. So relocating is 
decision.
    But in this case one Drill test 
[DRILL-3938](https://github.com/apache/drill/pull/1111/files#diff-0f8deff45b06e709ba2ae35f96274076R395)
 is failed, because Parquet 1.8.0 version started to prohibit empty 
struct/groups on MessageType level 
[PARQUET-278](https://issues.apache.org/jira/browse/PARQUET-278). 
    But from 1.8.1 version it is 
[allowed](https://github.com/apache/parquet-mr/pull/263/files#diff-1ae59a3502695f53cb2d0371e1116c63L92)
 again - [PARQUET-363](https://issues.apache.org/jira/browse/PARQUET-363).
    
    So Drill parquet-column version without throwing an Exception solves the 
issue. 
    For Hive2.3 it can be changed.



---

Reply via email to