[GitHub] drill pull request #1119: DRILL-6143: Made FragmentsRunner's rpc timeout a S...

[Ben-Zvi]

Github user Ben-Zvi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1119#discussion_r167343642
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/SystemOptionManager.java
 ---
    @@ -212,7 +212,8 @@
           new OptionDefinition(ExecConstants.CPU_LOAD_AVERAGE),
           new OptionDefinition(ExecConstants.ENABLE_VECTOR_VALIDATOR),
           new OptionDefinition(ExecConstants.ENABLE_ITERATOR_VALIDATOR),
    -      new OptionDefinition(ExecConstants.OUTPUT_BATCH_SIZE_VALIDATOR, new 
OptionMetaData(OptionValue.AccessibleScopes.SYSTEM, true, false))
    +      new OptionDefinition(ExecConstants.OUTPUT_BATCH_SIZE_VALIDATOR, new 
OptionMetaData(OptionValue.AccessibleScopes.SYSTEM, true, false)),
    +      new 
OptionDefinition(ExecConstants.FRAG_RUNNER_RPC_TIMEOUT_VALIDATOR, new 
OptionMetaData(OptionValue.AccessibleScopes.SYSTEM, false, true)),
    --- End diff --
    
    Question: Should the last two parameters be instead:
       adminOnly = true
       internal = false 



---