Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1123#discussion_r168777666
--- Diff: exec/java-exec/src/main/codegen/templates/AggrTypeFunctions1.java
---
@@ -102,7 +102,20 @@ public void add() {
</#if>
nonNullCount.value = 1;
<#if aggrtype.funcName == "min">
- value.value = Math.min(value.value, in.value);
+ <#if type.inputType?contains("Float4") ||
type.inputType?contains("Float8")>
--- End diff --
1. Please mind original indent.
2. Please add comment describing how we chose min / max for nan / inf
values.
3. Please consider using if without nested if: `if - elseif - else`.
---
