Github user paul-rogers commented on the issue:
    See [this 
 and [this 
 for examples of one way to address some of the comments made in the code 
review. That example handles projection, which was mentioned in one of the 
review comments.
    Since the regex is file-specific, the regex format plugin is most useful if 
it can be configured per-file using table functions. See 
[DRILL-6168]( and 
[DRILL-6169]( for problems 
that will be encountered. See the example and tests above for how to work 
around the bugs.
    Although I suggested looking at the `ResultSetLoader`, it is a bit 
premature to do so. That mechanism relies on additional mechanisms that have 
not yet been committed to master. So, we need to work with the mechanisms we 
have now. See the example reader above for how to cache the per-column mutator 
needed to write to vectors without the switch statements in the code in this PR.
    To generalize, the example has an object per column that holds per-column 
info. The example uses only `VarChar` columns. To add additional types, create 
a base column state class with subclasses for each type. Then, simply call a 
`save(String value)` method to write a column. That method can handle nulls 
(for projected non-existent columns) and type conversions (where needed).
    Finally, feel free to borrow liberally from the example. (The example was 
created for our Drill book, so is fair game to reuse.)


Reply via email to