Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1131#discussion_r170629893
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetFilterBuilder.java
 ---
    @@ -261,6 +273,37 @@ private LogicalExpression 
handleCompareFunction(FunctionHolderExpression functio
         }
       }
     
    +  private LogicalExpression handleIsFunction(FunctionHolderExpression 
functionHolderExpression, Set<LogicalExpression> value) {
    +    String funcName;
    +
    +    if (functionHolderExpression.getHolder() instanceof 
DrillSimpleFuncHolder) {
    +      funcName = ((DrillSimpleFuncHolder) 
functionHolderExpression.getHolder()).getRegisteredNames()[0];
    +    } else {
    +      logger.warn("Can not cast {} to DrillSimpleFuncHolder. Parquet 
filter pushdown can not handle function.",
    +          functionHolderExpression.getHolder());
    +      return null;
    +    }
    +    LogicalExpression arg = functionHolderExpression.args.get(0);
    +
    +    switch (funcName) {
    --- End diff --
    
    Please use proper formatting for switch case.


---

Reply via email to