Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1139#discussion_r171510779
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java ---
@@ -91,6 +91,34 @@
static {
userConnectionMap = new ConcurrentHashMap<>();
}
+ public static String safeLogString(UserToBitHandshake inbound) {
--- End diff --
1. Please remove one space -> `static String`/
2. Can this method be just private? Not public static? If yes, please move
it to the end of the class.
3. Please add javadoc to the method.
4. Please consider method renaming to depict actual work it does.
---
