Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1125#discussion_r172104027
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatchSizer.java 
---
    @@ -36,13 +39,17 @@
     import org.apache.drill.exec.vector.VariableWidthVector;
     
     import com.google.common.collect.Sets;
    +import 
org.apache.drill.exec.vector.complex.RepeatedVariableWidthVectorLike;
     
     /**
      * Given a record batch or vector container, determines the actual memory
      * consumed by each column, the average row, and the entire record batch.
      */
     
     public class RecordBatchSizer {
    +  private static final int OFFSET_VECTOR_WIDTH = 4;
    --- End diff --
    
    Perhaps use `UInt4Vector.VALUE_WIDTH` to initialize this constant. Use 
`UInt1Vector.VALUE_WIDTH` for the bit vector width.


---

Reply via email to