Github user sohami commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1153#discussion_r173031821
  
    --- Diff: exec/java-exec/src/main/resources/rest/index.ftl ---
    @@ -247,11 +253,14 @@
                     $("#row-"+i).find("#queriesCount").text("");
                 }
                 else {
    -                if( status_map[key] == "ONLINE") {
    +                if (status_map[key] == "ONLINE") {
                         $("#row-"+i).find("#status").text(status_map[key]);
                     }
                     else {
    -                    fillQueryCount(address,i);
    +                    var is_ssl_enabled = $('#ssl').val();
    +                    if (is_ssl_enabled != "ssl_enabled") {
    +                        fillQueryCount(address,i);
    --- End diff --
    
    `fillQueryCount` should also handle the case for Https and Http just like 
`shutdown`. Looks like currently with this change if SSL is enabled then we 
won't be able to get the queryCount of Drillbit shutting down.
    Why not handle it in same way as for `shutdown` method ?


---

Reply via email to