Github user vrozov commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1163#discussion_r174551433
  
    --- Diff: common/src/main/java/org/apache/drill/common/AutoCloseables.java 
---
    @@ -25,6 +25,11 @@
      */
     public class AutoCloseables {
     
    +  public interface Closeable extends AutoCloseable {
    --- End diff --
    
    It is on purpose:
    - There is a minimal difference between Drill `Closeable` and Java 
'Closeable/AutoCloseable`, so name reflects that.
    - It won't be possible to use Drill `Closeable` in place of Java 
`Closeable/AutoCloseable` in case `close()` throws checked exception.
    - Drill `Closeable` is not a top level interface, so where it is necessary 
to distinguish Drill `Closeable` from Java `Closeable` full name 
`AutoClosables.Closeable` should be used.


---

Reply via email to