Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1181#discussion_r178445267
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/MergeJoinBatch.java
 ---
    @@ -573,4 +610,21 @@ private LogicalExpression 
materializeExpression(LogicalExpression expression, It
         }
         return materializedExpr;
       }
    +
    +  private void updateStats() {
    +    stats.setLongStat(MergeJoinBatch.Metric.LEFT_INPUT_BATCH_COUNT, 
mergeJoinMemoryManager.getNumIncomingBatches(LEFT_INDEX));
    +    stats.setLongStat(MergeJoinBatch.Metric.LEFT_AVG_INPUT_BATCH_BYTES, 
mergeJoinMemoryManager.getAvgInputBatchSize(LEFT_INDEX));
    +    stats.setLongStat(MergeJoinBatch.Metric.LEFT_AVG_INPUT_ROW_BYTES, 
mergeJoinMemoryManager.getAvgInputRowWidth(LEFT_INDEX));
    +    stats.setLongStat(MergeJoinBatch.Metric.LEFT_TOTAL_INPUT_RECORDS, 
mergeJoinMemoryManager.getTotalInputRecords(LEFT_INDEX));
    +
    +    stats.setLongStat(MergeJoinBatch.Metric.RIGHT_INPUT_BATCH_COUNT, 
mergeJoinMemoryManager.getNumIncomingBatches(RIGHT_INDEX));
    +    stats.setLongStat(MergeJoinBatch.Metric.RIGHT_AVG_INPUT_BATCH_BYTES, 
mergeJoinMemoryManager.getAvgInputBatchSize(RIGHT_INDEX));
    +    stats.setLongStat(MergeJoinBatch.Metric.RIGHT_AVG_INPUT_ROW_BYTES, 
mergeJoinMemoryManager.getAvgInputRowWidth(RIGHT_INDEX));
    +    stats.setLongStat(MergeJoinBatch.Metric.RIGHT_TOTAL_INPUT_RECORDS, 
mergeJoinMemoryManager.getTotalInputRecords(RIGHT_INDEX));
    +
    +    stats.setLongStat(MergeJoinBatch.Metric.OUTPUT_BATCH_COUNT, 
mergeJoinMemoryManager.getNumOutgoingBatches());
    +    stats.setLongStat(MergeJoinBatch.Metric.AVG_OUTPUT_BATCH_BYTES, 
mergeJoinMemoryManager.getAvgOutputBatchSize());
    +    stats.setLongStat(MergeJoinBatch.Metric.AVG_OUTPUT_ROW_BYTES, 
mergeJoinMemoryManager.getAvgOutputRowWidth());
    +    stats.setLongStat(MergeJoinBatch.Metric.TOTAL_OUTPUT_RECORDS, 
mergeJoinMemoryManager.getTotalOutputRecords());
    --- End diff --
    
    As above, maybe also write the information to the log for easier debugging.


---

Reply via email to