[GitHub] drill pull request #1200: DRILL-143: Support CGROUPs resource management

[paul-rogers]

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1200#discussion_r179027582
  
    --- Diff: distribution/src/resources/drillbit.sh ---
    @@ -154,6 +192,7 @@ start_bit ( )
       nohup nice -n $DRILL_NICENESS "$DRILL_HOME/bin/runbit" exec ${args[@]} 
>> "$logout" 2>&1 &
       echo $! > $pid
       sleep 1
    +  check_after_start
    --- End diff --
    
    To make things easier:
    
    ```
    procId=$!
    echo $procId > $pid # Yeah, $pid is a file, $procId is the pid...
    sleep 1
    check_after_start $procId
    ```
    
    Also, we now have to naming conventions: `waitForProcessEnd` and 
`check_after_start`. Doesn't match which we choose, but we should stick with 
it. Where is check style for scripts?


---