Github user vrozov commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1207#discussion_r181197514
  
    --- Diff: pom.xml ---
    @@ -198,6 +200,78 @@
     
       <build>
         <plugins>
    +      <plugin>
    +        <groupId>org.apache.rat</groupId>
    +        <artifactId>apache-rat-plugin</artifactId>
    +        <version>0.12</version>
    +        <executions>
    +          <execution>
    +            <id>rat-checks</id>
    +            <phase>validate</phase>
    +            <goals>
    +              <goal>check</goal>
    +            </goals>
    +          </execution>
    +        </executions>
    +        <configuration>
    +          <skip>${rat.skip}</skip>  <!-- DRILL-6320 License checks are 
intentionally skipped by default for development -->
    --- End diff --
    
    Is this necessary? Should not `<skip>` use `rat.skip` property by default?


---

Reply via email to