Github user ppadma commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1218#discussion_r182923416
  
    --- Diff: 
exec/java-exec/src/test/java/org/apache/drill/test/rowSet/test/TestIndirectReaders.java
 ---
    @@ -0,0 +1,151 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.test.rowSet.test;
    +
    +import static org.junit.Assert.*;
    +
    +import org.apache.drill.common.types.TypeProtos.MinorType;
    +import org.apache.drill.exec.record.metadata.TupleMetadata;
    +import org.apache.drill.exec.record.selection.SelectionVector2;
    +import org.apache.drill.exec.vector.accessor.ArrayReader;
    +import org.apache.drill.exec.vector.accessor.ArrayWriter;
    +import org.apache.drill.exec.vector.accessor.ScalarReader;
    +import org.apache.drill.exec.vector.accessor.ScalarWriter;
    +import org.apache.drill.test.SubOperatorTest;
    +import org.apache.drill.test.rowSet.RowSetWriter;
    +import org.apache.drill.test.rowSet.RowSet.ExtendableRowSet;
    +import org.apache.drill.test.rowSet.RowSet.SingleRowSet;
    +import org.apache.drill.test.rowSet.schema.SchemaBuilder;
    +import org.apache.drill.test.rowSet.RowSetComparison;
    +import org.apache.drill.test.rowSet.RowSetReader;
    +import org.junit.Test;
    +
    +/**
    + * Test reading with an indirection vector (sv2.) This form of
    + * indirection vector reorders values within a single batch.
    + * Since the indirection occurs only in the reader index, only
    + * light testing is done; all readers go through the same index class,
    + * so if the index works for one reader, it will for for all.
    --- End diff --
    
    typo: it will work for all (instead of for for all)


---

Reply via email to