Github user Ben-Zvi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1227#discussion_r182898395
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java
 ---
    @@ -147,7 +150,19 @@
         NUM_BUCKETS,
         NUM_ENTRIES,
         NUM_RESIZING,
    -    RESIZING_TIME_MS;
    +    RESIZING_TIME_MS,
    +    LEFT_INPUT_BATCH_COUNT,
    +    LEFT_AVG_INPUT_BATCH_BYTES,
    +    LEFT_AVG_INPUT_ROW_BYTES,
    +    LEFT_INPUT_RECORD_COUNT,
    +    RIGHT_INPUT_BATCH_COUNT,
    +    RIGHT_AVG_INPUT_BATCH_BYTES,
    +    RIGHT_AVG_INPUT_ROW_BYTES,
    +    RIGHT_INPUT_RECORD_COUNT,
    +    OUTPUT_BATCH_COUNT,
    +    AVG_OUTPUT_BATCH_BYTES,
    +    AVG_OUTPUT_ROW_BYTES,
    +    OUTPUT_RECORD_COUNT;
    --- End diff --
    
    The metrics are to be used also by customers; is this information relevant 
for them ? Is this too detailed (e.g., can be logged instead).
     


---

Reply via email to