[GitHub] drill pull request #1234: DRILL-5927: Fixed memory leak in TestBsonRecordRea...

[vrozov]

Github user vrozov commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1234#discussion_r183747252
  
    --- Diff: 
exec/java-exec/src/test/java/org/apache/drill/exec/store/bson/TestBsonRecordReader.java
 ---
    @@ -272,6 +276,9 @@ public static void cleanUp() {
         } catch (Exception e) {
     
         }
    +
    +    buffer.close();
    --- End diff --
    
    IMO `close()` should be used within try-with-resources only (no explicit 
calls to `close()`).


---