Github user vrozov commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1189#discussion_r184243564
  
    --- Diff: logical/pom.xml ---
    @@ -85,14 +85,12 @@
         </dependency>
         
         <dependency>
    -      <groupId>com.codahale.metrics</groupId>
    +      <groupId>io.dropwizard.metrics</groupId>
    --- End diff --
    
    It is not a best practice to rely on a transitive dependency for a compile 
scope dependency. I'd recommend specifying the dependency on 
`io.dropwizard.metrics` explicitly in case `java-exec` or `drill-memory-base` 
uses it.


---

Reply via email to