Github user vrozov commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1237#discussion_r184586222
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java
 ---
    @@ -149,25 +149,32 @@ private RawFragmentBatch getNextBatch() throws 
IOException {
         }
       }
     
    +  private RawFragmentBatch getNextNotEmptyBatch() throws IOException {
    --- End diff --
    
    No, there is no need to handle `IOException` twice. There are no other 
methods that throw `IOException`. `SchemaChangeException` is actually never 
thrown. Please see *TODO* comment and DRILL-2933.


---

Reply via email to