GitHub user kkhatua opened a pull request:
https://github.com/apache/drill/pull/1241
DRILL-6364: Handle Cluster Info in WebUI when existing/new bits restart
As a follow up to DRILL-6289, the following improvements have been done:
1. When loading the page for the first time, the WebUI enables the shutdown
button without actually checking the state of the Drillbits.
The ideal behaviour should be to disable the button till the state is
verified. **[Done]**
_If a Drillbit is confirmed down (i.e. not in `/state` response), it is
marked as OFFLINE and button is disabled._
2. When shutting down the current Drillbit, the WebUI no more has access to
the cluster state.
The ideal behaviour here should be to fetch the state from any of the
other Drillbits to update the status. **[Done]**
_With the current Drillbit down, the other bits are requested for
cluster state info and update accordingly._
3. When a new, previously unseen Drillbit comes up, the WebUI will never
render it because the table is statically generated during the first page load.
The idea behaviour should be to append to the table on discovery of a
new node. **[Done]**
_The new Drillbit info is injected and a prompt appears to refresh the
page to re-populate any missing info. This also works with feature (2)
mentioned above._
The only Java code change was to have the state response carry the address
and http-port as a tuple, instead of the user-port (which seems to be never
used).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kkhatua/drill DRILL-6364
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/1241.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1241
----
commit ab3e8619c6259803eb362be290a3a3605839a194
Author: Kunal Khatua <kunal@...>
Date: 2018-04-27T23:27:45Z
DRILL-6364: Handle Cluster Info in WebUI when existing/new bits restart
As a follow up to DRILL-6289, the following improvements have been done:
1. When loading the page for the first time, the WebUI enables the shutdown
button without actually checking the state of the Drillbits.
The ideal behaviour should be to disable the button till the state is
verified. [Done]
If a Drillbit is confirmed down (i.e. not in `/state` response), it is
marked as OFFLINE and button is disabled.
2. When shutting down the current Drillbit, the WebUI no more has access to
the cluster state.
The ideal behaviour here should be to fetch the state from any of the
other Drillbits to update the status. [Done]
With the current Drillbit down, the other bits are requested for cluster
state info and update accordingly.
3. When a new, previously unseen Drillbit comes up, the WebUI will never
render it because the table is statically generated during the first page load.
The idea behaviour should be to append to the table on discovery of a
new node. [Done]
The new Drillbit info is injected and a prompt appears to refresh the
page to re-populate any missing info. This also works with feature (2)
mentioned above.
The only Java code change was to have the state response carry the address
and http-port as a tuple, instead of the user-port (which is never used).
----
---
