Ted as usual puts it succinctly. It doesn't matter what the nature of the change, the author name should be accurate.
Not blaming anyone, we frequently look to other projects to learn how things are done. Let's just not do it in Drill. On Fri, May 11, 2018 at 3:10 PM, Ted Dunning <[email protected]> wrote: > Tim, > > It is important to attribute *all* changes to after real person. If you > make a change, we should track back to you. If you, as a committer accept a > change from someone else, the original author should be preserved and your > name should be recorded as well. > > A big claim that is made by all Apache projects is that provenance of all > changes is documented. We have to support that claim by credit the right > person. > > On Fri, May 11, 2018, 12:51 Timothy Farkas <[email protected]> wrote: > > > Hi Parth, > > > > I'm the culprit for that. It was suggested during the code review for my > > change that sweeping formatting only changes should be attributed to a > fake > > Drill Dev user. Having this separate commit was approved by the reviewer > > when my change was reviewed. This practice is also done in other open > > source projects such as Apache Apex, see an example of such a commit here > > https://github.com/apache/apex-core/commit/ > 4a91c30c25c0c10562aec4350fb03e40a06d4a89 > > . > > > > If this is not the right way to go about things, how should formatting > > only changes be committed? I will likely be making more formatting > changes > > as I improve the checkstyle checks and want to make sure I follow the > right > > process. > > > > Thanks, > > Tim > > > > ________________________________ > > From: Parth Chandra <[email protected]> > > Sent: Friday, May 11, 2018 11:59:09 AM > > To: dev > > Subject: Drill commits with improper author name > > > > Can we please not use Drill-Dev as the author email? > > Committers please watch out and ask contributors to provide a valid > email. > > > > > > > > > > > > This is an automated email from the ASF dual-hosted git repository. > > > > > > in repository > > https://urldefense.proofpoint.com/v2/url?u=https-3A__gitbox. > apache.org_repos_asf_drill.git&d=DwIBaQ&c=cskdkSMqhcnjZxdQVpwTXg&r= > 4eQVr8zB8ZBff-yxTimdOQ&m=lfd0vh9Lq713LfH65fSXfgqQoh7qpIEQoZn76R_h5Gw&s= > MyvLwOdgKMfhD1RWp15iDV39r8xI1ry9kkC6zcMsZL8&e= > > > > > > commit 8a1a7c53fb211dcba6e7b2f2ce90c28af4b9c518 > > > Author: Drill Dev <[email protected]> > > > AuthorDate: Tue May 8 13:57:37 2018 -0700 > > > > > > DRILL-6386: Remove unused imports and star imports. > > > --- > > > > > > > > >
