Ben-Zvi commented on a change in pull request #1324: DRILL-6310: limit batch
size for hash aggregate
URL: https://github.com/apache/drill/pull/1324#discussion_r198712153
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggBatch.java
##########
@@ -263,13 +343,13 @@ private HashAggregator createAggregatorInternal() throws
SchemaChangeException,
// add this group-by vector to the output container
groupByOutFieldIds[i] = container.add(vv);
+ columnMapping.put(outputField.getName(),
ne.getRef().getAsNamePart().getName());
Review comment:
The regressions *TestHashAggEmitOutcome* set the "name" and the "expr" to
different strings, hence the failure above. So I changed this to:
```
columnMapping.put(outputField.getName(),
ne.getExpr().toString().replace('`',' ').trim() );
```
To make the regressions (e.g. **testHashAggrMultipleEMITOutcome()**) pass.
It is a little ugly (removing the '`' before and after), but I could not
think of something nicer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
