vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning
for multi rowgroup parquet file
URL: https://github.com/apache/drill/pull/1298#discussion_r198882164
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetComparisonPredicate.java
##########
@@ -83,23 +84,26 @@ private ParquetComparisonPredicate(
* where Column1 and Column2 are from same parquet table.
*/
@Override
- public boolean canDrop(RangeExprEvaluator<C> evaluator) {
+ public RowsMatch matches(RangeExprEvaluator<C> evaluator) {
Statistics<C> leftStat = left.accept(evaluator, null);
- if (isNullOrEmpty(leftStat)) {
- return false;
+ if (isNullOrEmpty(leftStat) || !leftStat.hasNonNullValue()) {
Review comment:
The check for `hasNonNullValue()` should be done after check for
`isAllNulls()` or, otherwise, it will always return `SOME` when all values are
null.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
