ppadma commented on a change in pull request #1324: DRILL-6310: limit batch
size for hash aggregate
URL: https://github.com/apache/drill/pull/1324#discussion_r199023543
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/common/HashTableTemplate.java
##########
@@ -683,7 +683,7 @@ public PutStatus put(int incomingRowIdx, IndexPointer
htIdxHolder, int hashCode)
}
htIdxHolder.value = currentIdx;
return addedBatch ? PutStatus.NEW_BATCH_ADDED :
- ( freeIndex + 1 > totalBatchHoldersSize /* batchHolders.size() *
BATCH_SIZE */ ) ?
+ (freeIndex + 1 > (batchHolders.size() * BATCH_SIZE)) ?
Review comment:
@Ben-Zvi yes, agree. I am computing and saving these values when a new batch
gets added/removed. We can use the saved values instead of computing every time
for each row. Please look at "code review comments - 2".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
