sachouche commented on a change in pull request #1330: DRILL-6147: Adding
Columnar Parquet Batch Sizing functionality
URL: https://github.com/apache/drill/pull/1330#discussion_r199031792
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/VarLenColumnBulkInput.java
##########
@@ -311,6 +372,113 @@ private void loadPageIfNeeed() throws IOException {
}
}
+ private boolean batchConstraintsReached() {
+ // Let's update this column's memory quota
+ columnMemoryQuota =
batchSizerMgr.getCurrentFieldBatchMemory(parentInst.valueVec.getField().getName());
+ assert columnMemoryQuota.getMaxMemoryUsage() > 0;
+
+ // Now try to figure out whether the next chunk will take us beyond the
memory quota
+ final int maxNumRecordsInChunk = VarLenBulkPageReader.BUFF_SZ /
BatchSizingMemoryUtil.INT_VALUE_WIDTH;
Review comment:
This is related to the Bulk Entry containing a maximum of 1024 values (for a
4k buffer).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
