arina-ielchiieva commented on a change in pull request #1348: DRILL-6346:
Create an Official Drill Docker Container
URL: https://github.com/apache/drill/pull/1348#discussion_r199138669
##########
File path: distribution/pom.xml
##########
@@ -485,6 +485,36 @@
</plugins>
</build>
</profile>
+ <profile>
+ <!-- this profile adds/overrides few features of the 'apache-release'
+ profile in the parent pom. -->
+ <id>apache-release</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>com.spotify</groupId>
+ <artifactId>dockerfile-maven-plugin</artifactId>
+ <version>1.4.3</version>
+ <executions>
+ <execution>
+ <id>docker-image</id>
+ <goals>
+ <goal>build</goal>
+ <goal>push</goal>
+ </goals>
+ </execution>
+ </executions>
+ <configuration>
+ <repository>drill/apache-drill-centos</repository>
Review comment:
1. We might want to make this configurable?
2. Why docker image build will be available only in apaceh-release profile?
What if user want to create image and push it to its own repo?
3. `drill/apache-drill-centos` does committers have access to this repo to
do the push?
4. https://github.com/parthchandra/drill/wiki/Drill-Release-Process should
be updated with instructions about Docker.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
