sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199315728
########## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsHandler.java ########## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.drill.exec.store; + +import org.apache.drill.common.logical.StoragePluginConfig; +import org.apache.drill.exec.planner.logical.StoragePlugins; +import org.apache.drill.exec.store.sys.PersistentStore; + + +/** + * Storage plugins handler is an additional service for updating storage plugins configs from the file + */ +public interface StoragePluginsHandler { + + /** + * Update incoming storage plugins configs from persistence store if present, otherwise bootstrap plugins configs. + * One of the params should be null, second shouldn't + * + * @param persistentStore the last storage plugins configs from persistence store + * @param bootstrapPlugins bootstrap storage plugins, which are used in case of first Drill start up + * @return all storage plugins, which should be loaded into persistence store + */ + void loadPlugins(PersistentStore<StoragePluginConfig> persistentStore, StoragePlugins bootstrapPlugins); Review comment: - One is not true since with current approach, let say if there are N plugins in store. 1) Caller of `loadPlugins` will get all the plugins from `persistentStore` and assign `bootstrapPlugins` to null or non-null value. There will be N calls internally to PStore. 2) Then inside loadPlugins if there is newPluginConfig present it will iterate for each plugin config, get that plugin config from persistent store and then write the update plugin config to the store. For each plugin there is get and put call so total 2N calls here. So overall there are 3N calls to the PStore. Whereas if caller is directly passing list of plugins whether it be built using bootstrap or persistentStore, it makes N call for that. And later when it gets back updated plugin from loadPlugins method then it writes those one by one to the PStore which is again N calls to PStore hence overall there are 2N calls. - My personal opinion is registry should only use the store rather than this handler since registry creates it as well. And that way all read and write to store is also happening at once place (i.e. in registry). I will leave the choice up to you. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
