vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins
Handler
URL: https://github.com/apache/drill/pull/1345#discussion_r199357677
##########
File path:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/schema/HiveSchemaFactory.java
##########
@@ -52,18 +50,18 @@
public class HiveSchemaFactory implements SchemaFactory {
static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(HiveSchemaFactory.class);
- // MetaStoreClient created using process user credentials
- private final DrillHiveMetaStoreClient processUserMetastoreClient;
- // MetasStoreClient created using SchemaConfig credentials
- private final LoadingCache<String, DrillHiveMetaStoreClient>
metaStoreClientLoadingCache;
+ // MetaStoreClient created using process user credentials. Null if client
can't be instantiated
+ private DrillHiveMetaStoreClient processUserMetastoreClient;
Review comment:
It may not be initialized in the constructor. It was done to avoid `null`
value in Hive storage plugin update window.
But I don't like this approach anymore.
I have described the issue here:
[DRILL-6412](https://issues.apache.org/jira/browse/DRILL-6412?focusedCommentId=16528944&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16528944).
I think until it will be solved as mentioned in DRILL-6412, the workaround
could be used,: `"hive.metastore.schema.verification": "false"` property in
Hive `bootstrap-storage.json`. It allows instantiate Hive client properly as in
earlier 1.2 version of Drill Hive client.
Also this properties should be documented for configuring Hive Embedded
Metastore:
https://drill.apache.org/docs/hive-storage-plugin/#hive-embedded-metastore-configuration
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
