weijietong commented on a change in pull request #1334: DRILL-6385: Support
JPPD feature
URL: https://github.com/apache/drill/pull/1334#discussion_r199374038
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/HashJoinPOP.java
##########
@@ -32,35 +33,53 @@
import com.google.common.base.Preconditions;
import com.google.common.collect.Lists;
import org.apache.drill.exec.physical.base.AbstractJoinPop;
+import org.apache.drill.exec.work.filter.RuntimeFilterDef;
+
@JsonTypeName("hash-join")
+@JsonIgnoreProperties(ignoreUnknown = true)
Review comment:
The primary reason is to backward compatible. PhysicalPlans without
`runtimeFilterDef` property (maybe not support RuntimeFilter) can still work
out. That is the `ignoreUnknown=true` usage. The `@JsonIgnore` is to not
output the property content as the final json. That's not our target.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
