vrozov commented on a change in pull request #1361: DRILL-6579: Added sanity
checks to the Parquet reader to avoid infini…
URL: https://github.com/apache/drill/pull/1361#discussion_r199978503
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/VarLenNullableFixedEntryReader.java
##########
@@ -38,14 +39,16 @@
/** {@inheritDoc} */
@Override
final VarLenColumnBulkEntry getEntry(int valuesToRead) {
- assert columnPrecInfo.precision >= 0 : "Fixed length precision cannot be
lower than zero";
+ Preconditions.checkArgument(columnPrecInfo.precision >= 0, "Fixed length
precision cannot be lower than zero");
Review comment:
Should the check be here or in the constructor?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
